Skip to content

x509.name.new: guard against non-table array elements (nil deref crash) #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samchang8826 wants to merge 1 commit into
base: v0.x
Choose a base branch
from
Open

x509.name.new: guard against non-table array elements (nil deref crash) #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/xname.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,12 @@ openssl_new_xname(lua_State *L, int idx, int utf8)

for (i = 0, n = lua_rawlen(L, idx), ret = 1; i < n && ret == 1; i++) {
lua_rawgeti(L, idx, i + 1);
if (!lua_istable(L, -1)) {
/* guard: non-table array element (e.g. {"CN=x"}) would make lua_next
* treat a string as a table and crash the process (nil deref). */
ret = 0;
break;
}
lua_pushnil(L);

while (lua_next(L, -2) != 0) {
Expand Down
Loading