Default User-Agent to versioned zernio-php/<version>/PHP#4
Open
Ooscaar wants to merge 1 commit into
Open
Conversation
Replace the static OpenAPI-Generator default with a lazy resolver that reads composer.json once at first use, so requests carry the SDK version. The generate.yml workflow re-applies the patch after each regeneration. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-Agentfromcomposer.jsonthe first timeConfiguration::getUserAgent()is called, producingzernio-php/<composer-version>/PHPinstead of the staticOpenAPI-Generator/1.0.0/PHP..github/workflows/generate.ymlafter eachopenapi-generator-cli generate, so the change survives every regeneration without depending on knowing the next version bump at generation time.setUserAgent().Test plan
php -l lib/Configuration.php— no syntax errorsnew Configuration().getUserAgent()returnszernio-php/0.0.293/PHPandsetUserAgent('custom/1.0')still overrides./vendor/bin/phpunit(withmemory_limit=512M) — all 6011 generated tests pass (same Incomplete status as on main)🤖 Generated with Claude Code