Formatting fixes - #412
Open
azarouski wants to merge 66 commits into
Open
Formatting fixes#412azarouski wants to merge 66 commits into
azarouski wants to merge 66 commits into
Conversation
Device containers in the devices and mac-devices roles now receive STORAGE_TOKEN, so screenshot uploads and app-install blob fetches pass the authenticated STF storage routes. The token is read from the environment to keep the value out of this tracked repository, and it must match STORAGE_TOKEN in the STF server variables.env. DEVICE_VERSION moves to 3.0-hardening-2026.08 so providers run the security-remediated device image that expects the token.
Updates the provider image reference and adds the new default values needed by the updated STF image.
Honour the 'wireless' field that has existed in mcloud-devices.txt since
it was introduced but was never read (fields 2-10, 12 and 13 are read;
11 is skipped).
Motivation
----------
Apple TV 4K has no diagnostic port. 'ios listen' therefore never emits a
connect event for it, so create_containers() is never called and the
device cannot join the farm. The device is reachable over Apple's
RemoteXPC tunnel, but that tunnel needs uid 0 and a tun interface on the
host, so it lives outside the container set.
Everything else in the stack already works for such a device, because the
pieces that matter are HTTP and env driven:
* the appium image builds appium:webDriverAgentUrl as
http://${WDA_HOST}:${WDA_PORT} (files/zbr-default-caps-gen.sh)
* the device image registers with STF as --serial ${DEVICE_UDID} from
env, and health-checks WDA over HTTP
* appium-xcuitest-driver explicitly supports running off macOS when
given webDriverAgentUrl (assertWdaHostSessionCapsSupported)
So the only thing that genuinely differs is where WebDriverAgent lives.
Change
------
For rows with wireless=true:
* skip the connector container -- it exists only to share usbmuxd
* omit the --link to it from the device and appium containers
* set WDA_HOST / WDA_PORT from two new device-list fields (14, 15)
* pass WIRELESS=true to the device and appium containers, consumed by
zebrunner/mcloud-device#210 and zebrunner/appium#439
Rows without wireless=true are untouched: same --link, same
WDA_HOST=connector, same connector container. Verified by simulation that
the docker arguments generated for a usb row are byte-identical.
WDA_PORT is now passed explicitly on the usb path too; both images
already default it to 8100, so that is a no-op.
Fails fast with an explicit message if wireless=true but no wda_host is
given, rather than starting containers that cannot work.
Notes
-----
Empty-array expansion uses ${arr[@]+"${arr[@]}"} because macOS ships
bash 3.2, where "${arr[@]}" on an empty array is an unbound-variable
error under 'set -u'.
No change is needed in listen()/on-usb-update: 'start <udid>' already
exists as a CLI verb, so an external owner of the tunnel can start and
stop these devices directly.
Verified end to end on an Apple TV 4K (AppleTV14,1) on tvOS 18.4 and
26.6: a Linux container with no Xcode, no macOS and no tunnel access
created an Appium session and drove the device (page source, screenshot,
button press, active app).
Support wireless (portless) iOS/tvOS devices by honouring the existing 'wireless' field
values for "wireless" were changed to lowercase
Wireless Apple devices setup fix
Change the way sudo permissions provided for ansible
Stf platform enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.