Repository navigation
Conversation
agy resolves the login keychain through the `security` CLI relative to $HOME, so the isolated profile homes used for warmup, models, usage probes, and interactive login failed with "keychain could not be found". Symlink the real ~/Library/Keychains into each spoofed home before spawning agy (macOS only, no-op elsewhere). Co-Authored-By: Warp <agent@warp.dev>
On macOS tempfile paths live under /var, a symlink to /private/var. Production code persists resolved paths (set_live_dir, profile resolution), so cursor keys, log event paths, and spawned HOME values come back resolved while tests compared unresolved ones. Resolve the temp base up front in both test modules. Co-Authored-By: Warp <agent@warp.dev>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
agy reaches the macOS login keychain through the
securityCLI, which resolves keychains relative to$HOME. agy-cli-manager spawns agy with isolated, spoofed homes (account dirs, runtime dir, temporary login home), so every manager-mediated agy run — login, warmup, models, usage/identity probes — fails with "keychain could not be found".Changes
_ensure_keychain_access(): on macOS, symlinkLibrary/Keychainsin the spoofed home to the real~/Library/Keychains; no-op on other platforms and failure-tolerant./usageidentity probe, and interactive login./var→/private/varsymlink: tests compared unresolved temp paths against production-resolved paths (set_live_dirpersists the resolved live dir), so resolve the temp base up front in both test modules.Verification
HOME,security default-keychainfails without the symlink and resolves the login keychain with it.Conversation: https://app.warp.dev/conversation/9fd1ad5b-45dd-49f5-9321-44feed4e6e85
Co-Authored-By: Warp agent@warp.dev