Repository navigation
Improve maps pages and map summaries - #1
Merged
Merged
Conversation
…oved player count to bottom right on mobile
…a bit more compact to reduce vertical space wasted
…a bit more compact to reduce vertical space wasted
…a bit more compact to reduce vertical space wasted
…a bit more compact to reduce vertical space wasted
Server page redesign
Fixed inconsistent flag scales
Added a page loading bar
…nto feat/activity-rework
… address and ok-style filters
A display order in the web only: the ruleset and the Ruleset page keep the ruleset's order. Making it the ruleset's own order is the lead's call.
Map boards hide the sort arrow until someone sorts, drop avatars on phones and put the gap under the time. The Maps tier column highlights the chosen tier in its color. Leaderboards fit the ranked number to a phone's first view, swapping points and completed on the Completed board. Server names are one bold face throughout. Ruleset code wraps; spacing fixes elsewhere.
The rank sits large in the header (one line under the name on phones) and follows the Style and Track menus; it's marked draft while the formula is. The picture is captioned as the latest world record or personal best, asked of the API. The strip below keeps completed maps and world records, compact. Personal bests open by place in the 2.0 view, loading every page until the API can sort; pre-2.0 views keep map order. WR rows are no longer highlighted, and the Any-style count is of rows, not maps.
Latest world records lead with the player, then the map, tier and style, then the time; on phones the map goes under the player. Records and Top players end level. The header's buttons get their own layer: with the depth canvas redrawing beneath, GPU Chromium dropped Find a server's hover color after a frame.
PR sourcejump#16 and the migration numbering, akanora's PRs and the plugin's new key requirement, the API options that would end the web's shortcuts, and the style-order question.
…ejump Map personal bests for servers in one request (now keyed), sign out everywhere (401 without a session), your own place pinned under a map board, one view for the tier in force (migration 0054, after PR sourcejump#16's 0052 and 0053), link previews and an error page, and the Windows build. The map board's rows keep this branch's phone layout inside sourcejump#25's EntryRow; design-system.md keeps both sides within its budget.
Redesign pass: profiles, home, phone tables; merge akanora's PRs sourcejump#24–sourcejump#29
Polish maps layout and tier filters
Simplify tier controls and map hover states
Simplify tier filters to plain links
Use compact chips for tier filters
Align tier filters in two balanced columns
Tighten tier badge and count spacing
Remove unused space around the tier filter
Restore the tier donut with a full-width All tiers control
Keep map summary details close and clarify tier filter states
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cd web && npm test -- --run src/features/maps/mapPodiums.test.tsnpm run test:ui -- e2e/maps-overview.e2e.ts e2e/maps-cards.e2e.ts