chore: improve cosign signature/attestation lookup with oras#4959
Open
Racer159 wants to merge 4 commits into
Open
chore: improve cosign signature/attestation lookup with oras#4959Racer159 wants to merge 4 commits into
Racer159 wants to merge 4 commits into
Conversation
Signed-off-by: Wayne Starr <me@racer159.com>
✅ Deploy Preview for zarf-docs canceled.
|
… retrieved) Signed-off-by: Wayne Starr <me@racer159.com>
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
brandtkeller
requested changes
Jun 5, 2026
Member
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
Minor requests otherwise this is neat to see.
Signed-off-by: Wayne Starr <me@racer159.com>
brandtkeller
approved these changes
Jun 5, 2026
Member
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
lgtm. clean and effective - technically a breaking change (public function signature modification) but I believe we're intending to have the policy list utils as not within the boundary.
I haven't seen any requests for this logic to support non-https registries and the current approach is still an improvement over what was here previously. That was the only thing that stood out between pull.go and the implementation here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This improves the speed of cosign signature and attestation lookups using
zarf dev find-imagesto encourage their use.Testing against the Neuvector UDS Package
registry1variant more than halved the totalfind-imagestime:This also aligns the authentication flow of this lookup with that of the image pull on create.
Related Issue
Fixes #N/A
Checklist before merging