test: fix typos in image discovery fixtures and test text#4945
test: fix typos in image discovery fixtures and test text#4945luojiyin1987 wants to merge 8 commits into
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
d05ed5f to
30af7d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
brandtkeller
left a comment
There was a problem hiding this comment.
Appreciate the PR - minor feedback otherwise straight forward. would love to hear more about what noise you are getting from the typos and any tooling recommendations you might have.
Thanks. This wasn’t causing much trouble in practice. I was already reading through the code and ran No strong recommendation from me beyond using |
Signed-off-by: luojiyin <luojiyin@hotmail.com>
7ddf9bb to
41e916b
Compare
Description
Fix several typo-only changes under
src/:src/internal/api/v1alpha1/validate_test.gosrc/pkg/packager/publish_test.goscratchfixture names infind-imagestestdatavalid-image-uritestdataThe fixture renames were checked to ensure they do not change image discovery behavior.
Tests run:
go test ./src/internal/api/v1alpha1 -run TestValidateChartgo test ./src/pkg/packager -run 'TestFindImages/(valid-image-uri)$|TestFindImages/(images found in archives)$|TestFindImages/(images found in different archives)$'\n\n## Related Issue\nRelates to Fix typos in tests and image discovery fixtures #4944\n\n## Checklist before merging\n- [x] Test, docs, adr added or updated as needed\n- [ ] Contributor Guide Steps followed\n\nCommits are GPG-signed. This PR is opened as draft because the branch still needs commit sign-off (Signed-off-by) to satisfy the contributor guide before merge.