Skip to content

test: fix typos in image discovery fixtures and test text#4945

Open
luojiyin1987 wants to merge 8 commits into
zarf-dev:mainfrom
luojiyin1987:chore/typos-src-fixes
Open

test: fix typos in image discovery fixtures and test text#4945
luojiyin1987 wants to merge 8 commits into
zarf-dev:mainfrom
luojiyin1987:chore/typos-src-fixes

Conversation

@luojiyin1987
Copy link
Copy Markdown

Description

Fix several typo-only changes under src/:

  • test case text in src/internal/api/v1alpha1/validate_test.go
  • comment text in src/pkg/packager/publish_test.go
  • scratch fixture names in find-images testdata
  • a container name typo in valid-image-uri testdata

The fixture renames were checked to ensure they do not change image discovery behavior.

Tests run:

  • go test ./src/internal/api/v1alpha1 -run TestValidateChart
  • go test ./src/pkg/packager -run 'TestFindImages/(valid-image-uri)$|TestFindImages/(images found in archives)$|TestFindImages/(images found in different archives)$'\n\n## Related Issue\nRelates to Fix typos in tests and image discovery fixtures #4944\n\n## Checklist before merging\n- [x] Test, docs, adr added or updated as needed\n- [ ] Contributor Guide Steps followed\n\nCommits are GPG-signed. This PR is opened as draft because the branch still needs commit sign-off (Signed-off-by) to satisfy the contributor guide before merge.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit e00f8ea
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6a18519b8d726a0008644ce5

Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Signed-off-by: luojiyin <luojiyin@hotmail.com>
@luojiyin1987 luojiyin1987 force-pushed the chore/typos-src-fixes branch from d05ed5f to 30af7d8 Compare May 28, 2026 02:05
@luojiyin1987 luojiyin1987 marked this pull request as ready for review May 28, 2026 02:07
@luojiyin1987 luojiyin1987 requested review from a team as code owners May 28, 2026 02:07
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the PR - minor feedback otherwise straight forward. would love to hear more about what noise you are getting from the typos and any tooling recommendations you might have.

Comment thread src/internal/api/v1alpha1/validate_test.go
@github-project-automation github-project-automation Bot moved this to In progress in Zarf May 28, 2026
@luojiyin1987
Copy link
Copy Markdown
Author

Appreciate the PR - minor feedback otherwise straight forward. would love to hear more about what noise you are getting from the typos and any tooling recommendations you might have.

Thanks. This wasn’t causing much trouble in practice. I was already reading through the code and ran typos during that pass, and it surfaced a few small wording/spelling inconsistencies like this one.

No strong recommendation from me beyond using typos as a lightweight optional check locally or in CI.

Signed-off-by: luojiyin <luojiyin@hotmail.com>
@luojiyin1987 luojiyin1987 force-pushed the chore/typos-src-fixes branch from 7ddf9bb to 41e916b Compare May 28, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

2 participants