Fix client side get_subprotocol() does not get populated #570 - #1196
Open
GreenLightning wants to merge 1 commit into
Open
Fix client side get_subprotocol() does not get populated #570#1196GreenLightning wants to merge 1 commit into
GreenLightning wants to merge 1 commit into
Conversation
handle_read_http_response() validated the server handshake and negotiated extensions but never read the Sec-WebSocket-Protocol response header, so a client that offered subprotocols always saw get_subprotocol() return an empty string even after the server selected one. Read the Sec-WebSocket-Protocol header from the response and validate it against the requested subprotocols. Then store it on the client, so it is available to end users (e.g. from the open handler) via get_subprotocol(). Add corresponding client role tests. Fixes zaphoyd#570
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR validates and stores the negotiated subprotocol on the client.
Corresponding tests have been added to
test/roles/client.cpp.Fixes #570