Add service healthchecks#578
Conversation
|
@derpixler @fliebe92 what do you think about this? Since @derpixler already added a health check for the railsserver, I think adding more for the base services makes sense. Now all defined |
There was a problem hiding this comment.
Pull request overview
This PR adds container healthchecks for core dependencies (Memcached, PostgreSQL, Redis) and updates depends_on to wait for those services to become healthy before starting Zammad services.
Changes:
- Switch
depends_onentries for Zammad services from simple startup ordering tocondition: service_healthy. - Add healthchecks for
zammad-memcached,zammad-postgresql, andzammad-redis. - Simplify the
zammad-railsserverhealthcheck definition formatting.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Looks good to me and - for sure - a step into the right direction! Thanks for addressing the point CoPilot mentioned. |
|
Would you like to approve, @fliebe92? |
@derpixler good point. I increased it to 60 seconds. For initializing an empty DB this sounds reasonable to me. |
fliebe92
left a comment
There was a problem hiding this comment.
-z sounds good for the nc command.
|
Can you have a look again, guys? I noticed more things, maybe for the future:
|
fliebe92
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the changes 💪🏻
No description provided.