feat: EBS Volumes tags inherit from labels #3123
Conversation
|
As an option we can make the config more generic with the possibility to extend it later (e.g. aws_resources_inherit_labels), so the labels can be extended to other aws resources. |
|
why can we not re-use the keys from |
The issue is we cannot add the application to the |
| t.Errorf("expected error: %v, got: %v", tc.err, err) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
why is there a diff on teams_test.go? Can you remove it from this PR?
|
I will go for a few weeks on vacations but I will go back to this PR after. Meanwhile please provide feedback on the approach @mikkeloscar. thanks |
Summary
This is another approach to solve the same problem as #3124
ebs_tags_inherit_labelsconfig option to propagate labels to EBS volume tagsDescribeVolumes) —CreateTagsis only called when a tag is missing or has changed valuepopulateVolumeMetaDatain bothmixedandebsstorage resize modesebs_tags_inherit_labelsthat are not in the PostgreSQL CR and are in the EBS tags are removedNOTE: This requires to add
ec2:CreateTagsandec2:DeleteTagsto the operator IAM role policyConfiguration
Test plan
NOTE: This PR was written in part with the assistance of generative AI