Skip to content

Check cluster UID #3019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mikkeloscar wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Check cluster UID #3019

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47de378
Check cluster UID
mikkeloscar Dec 18, 2025
deb5d3a
Merge branch 'master' into check-cluster-UID
FxKu Jun 25, 2026
33d89c1
Merge branch 'master' into check-cluster-UID
FxKu Jun 29, 2026
daabfff
Merge branch 'master' into check-cluster-UID
FxKu Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/controller/postgresql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,19 +185,25 @@ func (c *Controller) addCluster(lg *logrus.Entry, clusterName spec.NamespacedNam
func (c *Controller) processEvent(event ClusterEvent, isInInitialList bool) {
var clusterName spec.NamespacedName
var clHistory ringlog.RingLogger
var clusterUID types.UID
var err error

lg := c.logger.WithField("worker", event.WorkerID)

if event.EventType == EventAdd || event.EventType == EventSync || event.EventType == EventRepair {
clusterName = util.NameFromMeta(event.NewSpec.ObjectMeta)
clusterUID = event.NewSpec.UID
} else {
clusterName = util.NameFromMeta(event.OldSpec.ObjectMeta)
clusterUID = event.OldSpec.UID
}
lg = lg.WithField("cluster-name", clusterName)

c.clustersMu.RLock()
cl, clusterFound := c.clusters[clusterName]
if clusterFound && cl.UID != clusterUID {
clusterFound = false

@FxKu FxKu Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will lead to an error during deletion, see

postgres-operator/pkg/controller/postgresql.go

Line 297 in a3d17c1

case EventDelete:

Must be the reason why e2e tests always fail with the cluster deletion test (if they even get there)

}
if clusterFound {
clHistory = c.clusterHistory[clusterName]
}
Expand Down
Loading