Repository navigation
ci: drop the unhonoured pre-prune waiver (CACHE-034) - #606
Merged
Merged
Conversation
Local-Gate: v1 tree=944b9f80a842eed66746dc39139937b19f813d05 secs=53 lanes=lint:run
Ci-Attestation: {"at":1791244343,"gate":"python/all/lint","host":"linux-x86_64","key":"3c9bded47faae65dc67515007643b9a9ca1101b013371c6b4f3aaa0343151739","lane":"lint","parents":["19a40294a7358e2b761c7b142deb7654d1c5d519"],"secs":53,"stamp":"e19846e9e0fbe8207abdbe0f88329944","tree":"944b9f80a842eed66746dc39139937b19f813d05","v":1,"via":"run"}
7 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by zackees/ci.yml#352 (rule CACHE-034): this repository's
ci.tomldeclaredpre-prune = trueon[flow.main]-- its ONLY cache writer flow -- but nothing in the repository ever runsci-lint cache preprune(grep -rn "preprune" .github/ ci/returns nothing).ci_lint's CACHE-004 budget arithmetic honours the declaration on its own: the lockfile-change-peak term is dropped from the worst-case footprint purely on that line, so the modelled footprint was understated by the whole peak, for free.What changed
pre-prune = trueremoved from[flow.main], and the surrounding comment rewritten to record the decision instead of explaining the waiver favourably: the waiver is deliberately absent because no workflow honours it, citing zackees/ci.yml#352/#354/#360, and stating that restoring it requires a realci-lint cache preprunestep ordered ahead of the cache saves in the same run on a job holdingactions: write.Nothing else. No budget, family size, or cardinality edit. No workflow edit. No live cache entry touched.
Why (B) remove rather than (A) wire up a pre-prune step
This is fix (B) from zackees/ci.yml#354, tracked as a checklist item in zackees/ci.yml#360. Fleet precedent: zackees/bosn#533, zackees/reld#219. This repo declares the waiver on its only writer flow, so removing it brings the full lockfile-change peak back into CACHE-004's model.
CACHE-004 before vs after (from
ci-lint precheck --local, repo root)[cache.pr].budget[cache].budget)The honest model is over budget, so CACHE-004 now fires as a VIOLATION. That is the expected consequence of the fix, not a regression introduced by it: the waiver was masking an over-budget state. Same wall zackees/ci.yml#360 already records for soldr (soldr#3583) and running-process (running-process#1329) -- a separate budget/cardinality decision is owed there and here, and is deliberately out of scope for this PR (no budget or family numbers were changed).
Verification
uvx --from git+https://github.com/zackees/ci.yml@main ci-lint precheck --localrun from the repo root, before and after the change:936 violation(s), 0 approved exception(s), 65 needs_review; after937 violation(s), 0 approved exception(s), 64 needs_review.ci-lint local-gate runpassed 45/45 checks and stamped this PR head (Local-Gatetree944b9f80a842).