Repository navigation
Add end-to-end file-sharing acceptance driver - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34. Completes the final sub-issue of #35.
Changes
..writes and chmod from the container. Update the relevant Rust assertion and docs.~/mnt, saved shares, and tier behavior.The driver captures the private Xvfb viewer directly with ImageMagick
import, including its native video overlay and GTK dialogs. This provides the screenshot evidence without swapping the desktop image for a temporary grim layer.Verification
nix build .#docker-vm -o /tmp/docker-vm-issue-34-resultpassed; its check phase runs the Rust unit tests.python3 -m py_compile tests/file_sharing_e2e.pyandgit diff --checkpassed.The GPU hot folder appeared in 0.06 s. The driver confirmed a native H.264 first frame, unchanged container ID, a visible Thunar window, and a successful remote title drag. The read-only parent bind was also tested live with a writable child: container-created files appeared on the host with the host UID and no executable bits, while
.., symlink escapes, and chmod of the parent failed.