Repository navigation
Sharing 3/8: add confined read-only dirfs - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Adds a read-only FUSE passthrough filesystem for a selected host folder. Lookups walk from an open root directory descriptor using
O_NOFOLLOWfor every component. Only regular files and directories are visible; symlinks, devices, FIFOs and sockets are hidden. Reads stream through open file handles, and the mount is owner-only withro,nodev,nosuid,noexec.Verification:
nix build .#docker-vm -o /tmp/docker-vm-issue-29-resultpassed, including new unit tests for listing, reads, symlink and..refusal, and read-only behavior.dirfs.rsimplementation from a temporary Rust harness into a running private-Xvfb viewer session's drop zone.docker execreaddocs/hello.txtthrough/home/desktop/mnt/docs; an outside-pointing symlink was absent; creating a file returnedRead-only file system.findmntinside the container reportedfuse.dir ro,nosuid,nodev,noexecwith the session UID and GID. Unmount made the file disappear, and the exact test viewer PID was stopped with its container and mount directory removed.The native File menu will call this mount API on a worker thread in #32. Writable operations remain for #30.
CI follow-up: updated the existing
tests/validation.shstatic bind check for the tiered formatter introduced in #28../tests/validation.shnow passes locally (19 JavaScript and 3 Python tests, plus compose validation).