Skip to content

Sharing 1/8: add file-sharing tier setting and panel - #36

Merged
zackees merged 1 commit into
mainfrom
feat/issue-27-sharing-tier
Oct 18, 2026
Merged

zackees merged 1 commit into
mainfrom
feat/issue-27-sharing-tier

Conversation

@zackees

@zackees zackees commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Closes #27

Adds the off, encrypted, ro, and rw file-sharing setting, defaulting to ro for existing settings files. The viewer captures the effective tier at session start, supports DOCKER_VM_FILE_SHARING for one launch, and shows the saved and running tiers separately in Settings.

Verification:

  • nix build .#docker-vm -o /tmp/docker-vm-issue-27-result passed, including Rust unit tests.
  • On a private Xvfb display with a throwaway config, selected Read & write, clicked Restart session, then observed the replacement viewer report Running session: Read & write; the saved setting contained "file_sharing": "rw".
  • With a saved rw setting and DOCKER_VM_FILE_SHARING=off, the panel reported Running session: Off; saved setting: Read & write and listed the launch override.
  • Test viewers were terminated by exact PID; their containers and networks were removed.

This PR adds the tier setting and panel only. Drop-zone binding and mount enforcement are tracked in the subsequent sub-issues of #35.

@zackees
zackees merged commit 4a6ae0f into main Oct 18, 2026
1 check passed
@zackees
zackees deleted the feat/issue-27-sharing-tier branch October 18, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sharing 1/8: File sharing tier setting (off/encrypted/ro/rw) + env override + panel

1 participant