Upgrade to stable Effect v4 and fix reliability failures - #643
Merged
Merged
Conversation
This was referenced Oct 1, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin Effect to stable 4.0.0 and fix 19 reproduced failures in request cancellation, OAuth, paused execution, storage, artifacts and the operator UI. Public deployment APIs stay Promise-based, and the eight MCP tools retain their contracts.
Doctor now refuses redirects before deployment credentials can reach another origin. Duplicate API tool names fail at construction. Unreadable successful Notion responses fail without retrying a dispatched write. Accepted OAuth rotations survive owner cancellation and share one persistence operation, while disconnect generations remain fenced.
The PR also records the Effect MCP, Schema and HTTP evaluation. The MCP compatibility gate is tracked in #622.
Fixes
Validation
npm run release:checkpassed on the integrated candidate: 4,890 tests passed, 56 skipped, and 52 Chromium browser tests passed.providers:checkremains unavailable because Vercel's categorized reference no longer matches the inventory reader. Tracked separately in Restore the complete Vercel public MCP inventory check #642.Fresh Sol 6.1 review found no material issues on head
dcd1e075. Independent Sol verification installed dependencies from the lockfile, passed 4,890 Node/Workers tests and 20 additional synthetic probes, reproduced the local Effect evaluation, and passed the build, declaration, bundle, examples, security and Docker/package stages. Its local Chromium launch was blocked by the macOS sandbox before any browser case ran. GitHub CI run 36878740424 passed the fullrelease:checkon that exact head, including browser tests.Fixes #623. Fixes #624. Fixes #625. Fixes #626. Fixes #627.
Fixes #628. Fixes #629. Fixes #630. Fixes #631. Fixes #632.
Fixes #633. Fixes #634. Fixes #635. Fixes #636. Fixes #637.
Fixes #638. Fixes #639. Fixes #640. Fixes #641.