Skip to content

feat(ci): apply ADR-0022 branch shape check and issue link #489

Description

@ss-o

Summary

decisions/0022-issue-traceability-on-pull-requests.md was accepted in
z-shell/.github#594 and
implemented for the organization repository in z-shell/.github#600 and
z-shell/.github#601. This repository carries the same commit-lint.yml jobs
with their patterns inlined, so it needs the matching change or the two copies
drift, which ADR-0022 step 5 explicitly warns about.

What changes

  1. Validate Branch Name becomes a shape check. The identifier stops being
    mandatory:

    ^((feature|bug|hotfix)-[1-9][0-9]*(-[a-z0-9]+)*
     |(feat|fix|perf|refactor|docs|test|build|ci|style|chore|revert|feature|bug|hotfix)/[a-z0-9]+(-[a-z0-9]+)*)$
    

    feature-<id> stays valid and recommended. next keeps its
    persistent-integration exemption under
    decisions/0019-trunk-on-main-default.md, and the automation prefixes are
    unchanged.

  2. Validate Issue Link is added, matching the organization copy. It passes
    on an automation branch, a meta:no-issue label, or an issue reference in
    the pull-request body, and reports which applied. It reads only the
    pull_request event payload, so it needs no token.

Prerequisite

meta:no-issue has to exist as a label in this repository before the exemption
path is usable. It is declared in the organization catalog at
z-shell/.github:lib/labels.yml.

Note

code is not in the decisions/0003-conventional-commits.md type set, so
code/ branches remain rejected here as they do in the organization
repository. That was the accepted scope of ADR-0022.

Parent: z-shell/.github#595

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions