Repository navigation
feat: add Zi Setup terminal pilot - #1
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
ss-o
left a comment
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 265fdcb
No actionable findings remain on this exact head. The independent review verified that the four prior findings are resolved: Ctrl+C cannot cancel an in-flight apply, successful files results require a clean absolute receipt path, the zunit compatibility profile cannot be selectable, and all restricted fact values are validated.
Validation passed: go test -count=1 ./..., go test -race -count=1 ./..., go vet ./..., go mod tidy -diff, go mod verify, actionlint, and git diff --check main...HEAD. All 12 hosted PR checks are also green.
Residual evidence gaps: native macOS and Windows runtime behavior was not exercised locally, and this final pass did not repeat the earlier real-engine pseudo-terminal scenarios.
The setup engine is safe and reviewable, but its artifact paths, plan hashes, and phased apply contract are too low level for guided onboarding. This adds the standalone Go client that presents those exact artifacts without duplicating installer decisions.
The client provides Bubble Tea, plain, and headless flows over one workflow. It strictly validates
zi-setup-describe-v1,zi-setup-plan-v1, andzi-setup-result-v1; sanitizes all terminal text; shows generated Zsh and bounded file diffs; passes the reviewed plan hash to both apply phases; preserves partial failure results; and verifies a reopened plan has no content changes. Selectable profiles remain limited toloaderandannex;zunitis compatibility-only.The repository envelope includes GPL-3 licensing, Go 1.26 module pins, cross-platform Go CI, CodeQL, the organization commit-policy caller, and the review skill pinned to
z-shell/.github@ce74af22db3af827eed9558596275cdf3fb07505.Validation:
go test -count=1 ./...go test -race -count=1 ./...go vet ./...go mod tidy -diffandgo mod verifyactionlint .github/workflows/*.ymlplus YAML parsingsh ./tests/installers.shin the matchingz-shell/srcengine checkoutA verified engine-bundle bootstrap, release packaging, streaming apply events, and additional capability choices remain outside this pilot.
Closes z-shell/src#222