Repository navigation
ci: re-pin the code-review skill with bundled criteria - #232
Merged
Merged
Conversation
Reinstall the organization code-review skill at the approved revision ede9ed98, which adds references/criteria.md, and move the Org Routing caller to a07ed57c, whose approved record pins that revision and the criteria blob. Regenerate the AGENTS.md routing block for the new revision. Exclude .github/skills/code-review/** from Prettier and markdownlint: org-routing.py check compares vendored resource files byte for byte, so formatting them would break the pin. Refs z-shell/.github#747
Deploying src with
|
| Latest commit: |
87a032f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5c3a408c.zi-src.pages.dev |
| Branch Preview URL: | https://feature-747-repin-code-revie.zi-src.pages.dev |
6 tasks done
ss-o
commented
Oct 7, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 87a032f
Findings
No actionable findings on this head.
Scope: complete diff 0bfdc6e...87a032f, one commit, 5 files, reviewed against the organization code-review skill and its bundled criteria at this head. Refs z-shell/.github#747. Base main.
Note
Class 1 review under the ADR-0035 sole-maintainer exception. The maintainer declared that no second human reviewer is available and explicitly elected the exception for this pull request at 87a032f. This is a self-review by the agent that wrote the change, not an independent review or approval to merge.
Exception record
- Copilot request: Copilot code review is configured for
main(copilot_code_reviewrule). One request forcopilot-pull-request-reviewer[bot]was made at 2026-10-07T04:12:22Z on this head; the response listed no requested reviewer, and the timeline shows noreview_requestedevent and no Copilot review. Request not registered; the maintainer reports that Copilot usage limits are reached. - Separate read-only review: a separate reviewing session examined this same head without write access and reported no actionable findings. It independently confirmed that
references/criteria.mdis identical to z-shell/.github at ede9ed9, thatSKILL.mddiffers only in installer metadata, that the approved record at a07ed57 pins ede9ed9 with blobcb2520c5, that the second vendored skillzi-installstays current at its approved revision, thatorg-routing.py checkreports z-shell/src current, that the called workflow is identical at both caller pins, and that the Trunk exclusion is limited to Prettier and markdownlint on.github/skills/code-review/**. It is additional scrutiny by another session, not a second human.
Validation
- Passed (hosted, this head): 15 checks (1 skipped by their own conditions). Org Routing resolved its tooling at
workflow_shaa07ed57 and reportedorg routing for z-shell/src is current, which covers the skill pin, theSKILL.mddigest, thereferences/criteria.mdblob and the generatedAGENTS.mdblock. - Verified at this head: exactly the five expected files change;
SKILL.mdis blob200faa4fandreferences/criteria.mdis blobcb2520c5, byte-identical to the merged pilots; theAGENTS.mdand workflow changes are one line each; the Trunk change adds only the exclusion entry. Locally before commit:org-routing.py checkcurrent andtrunk checkclean on the changed files. - Unavailable: no Copilot review (request not registered). Runtime discovery of the skill and Copilot attribution remain unverified, as tracked in z-shell/.github#747.
Checklist verdicts and supporting evidence
- Provenance and integrity: pass. Reinstalled with
gh skill installat the approved full SHA ede9ed9. Before--force, the previous localSKILL.mdmatched the previously approved digest exactly, so no local change was overwritten. - CI pinning (IMPORTANT criteria): pass. The Org Routing caller moves from
893749ctoa07ed57, still a full SHA; the called workflow file is byte-identical at both commits, so only tooling and approved data change. - Formatter exclusion: pass, scoped. Prettier and markdownlint skip only
.github/skills/code-review/**, added to a newignorelist; other linters and any local skills are unaffected. - Generated content: pass. The
AGENTS.mdchange is only the regenerated routing line naming the new approved revision. - Source code: not applicable. No source, test or documentation content changes.
Limits and recovery
- This exception does not authorize deployment or a ruleset bypass; merge follows the normal ruleset.
- Recovery: reverting the squash commit restores the previous skill revision and caller pin together, which remain consistent with each other.
- A new head requires a new election and both reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs z-shell/.github#747. Re-pins the organization
code-reviewskill to the approved revision that bundles the z-shell review criteria, following the pilots in z-shell/zsh-eza#140 and z-shell/wiki#939..github/skills/code-review/: reinstalled withgh skill install z-shell/.github .github/skills/code-review --pin ede9ed9... --dir .github/skills --force. It now carriesreferences/criteria.md. Before--force, the localSKILL.mdmatched the previously approved digest exactly, so nothing local was overwritten..github/workflows/org-routing.yml: caller moves from893749ctoa07ed57, whose approved record pinsede9ed9and the criteria blobcb2520c5. The called workflow file is unchanged between the two commits.AGENTS.md: routing block regenerated withorg-routing.py applyfor the new revision..trunk/trunk.yaml: Prettier and markdownlint ignore.github/skills/code-review/**.org-routing.py checkcompares vendored resource files byte for byte, and Prettier realigns the tables incriteria.md.Validation
org-routing.py check --repository z-shell/srcwith z-shell/.github tooling ata07ed57: current, on the committed tree.git rev-parse HEAD:.github/skills/code-review/references/criteria.mdiscb2520c5, the approved resource id;SKILL.mdis byte-identical to the copies merged in ci: re-pin the code-review skill with bundled criteria zsh-eza#140 and ci: re-pin the code-review skill with bundled criteria wiki#939.trunk checkon the changed files: no issues.