Skip to content

docs(agents): repair organization instruction links - #230

Merged
ss-o merged 1 commit into
mainfrom
feature-717-org-links
Oct 6, 2026
Merged

ss-o merged 1 commit into
mainfrom
feature-717-org-links

Conversation

@ss-o

@ss-o ss-o commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Repair two organization links in AGENTS.md. refactor(agents): centralize knowledge and native delivery .github#718 moved the shell dialect dispatcher to .github/instructions/zsh/dialect-selection.instructions.md and the Zsh Scripting Standard to .github/instructions/zsh/scripting.instructions.md, so the old .github/instructions/shell.instructions.md and .github/instructions/zsh-scripting.instructions.md links return 404.

Refs z-shell/.github#717. This repository's guidance stays owned here; only the links change.

Verification

  • Every z-shell/.github main link in AGENTS.md resolves at organization main 020487ffd1bb1c209f317c855fb9a0ea0d107be5.
  • org-routing.py check --repository z-shell/src at the pinned organization revision 1becebb7b98dab717d82897428afafd792d4fb97: current.
  • trunk check on AGENTS.md: no issues. git diff --check passed.
  • The vendored .github/skills/code-review/SKILL.md still links two retired organization instruction files; it is refreshed through its approved revision, not edited here.

Agent handoff

No handoff needed.

The organization moved the shell dialect dispatcher and the Zsh scripting instruction under .github/instructions/zsh/, so the old links returned 404.

Refs z-shell/.github#717
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Deploying src with  Cloudflare Pages  Cloudflare Pages

Latest commit: 631ca50
Status: ✅  Deploy successful!
Preview URL: https://18738845.zi-src.pages.dev
Branch Preview URL: https://feature-717-org-links.zi-src.pages.dev

View logs

@ss-o ss-o left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fallback review under ADR-0026: Copilot request not registered on 631ca50

Findings

No actionable findings.

Scope: the complete diff of 631ca50e against base main at 0ec97ac9 (merge base), 1 file, +2/-2. Specification: z-shell/.github#717 and the organization paths at main 020487ffd1bb1c209f317c855fb9a0ea0d107be5.

Note

This is a maintainer-elected fallback self-review after the Copilot request did not register. It is not an independent review or approval to merge.

Review request record

  • 2026-10-06T00:38:02Z: POST /repos/z-shell/src/pulls/230/requested_reviewers with copilot-pull-request-reviewer[bot] on head 631ca50 returned success with an empty requested_reviewers list.
  • After 257 seconds the timeline held no Copilot review_requested event and no review existed. This pull request is not a draft. Review request not registered; cause unconfirmed.

Validation

  • Passed, hosted on this head: Linux and macOS ShellCheck, Linux and macOS Installer and Loader, Configured Zsh Lint, Analyze (actions), CodeQL, Org Routing, Installer contract impact, Installer contract detector tests, Cloudflare Pages, Validate Branch Name, Validate Commits, Validate Issue Link, Validate PR Title. Installer consumer evidence was skipped by its own condition.
  • Passed, local on this head: the org link scan of every tracked file against organization main, org-routing.py check at the pinned organization revision 1becebb7, git diff --check.
  • Signature: the commit is signed and GitHub reports it verified.
  • Skipped or unavailable: no shell source changed; the installer and loader suites ran hosted only.
Checklist verdicts and supporting evidence
  • Link targets: pass. .github/instructions/zsh/dialect-selection.instructions.md (title "Shell Dialect Dispatcher", applyTo: **/*.sh) and .github/instructions/zsh/scripting.instructions.md exist at organization main 020487ff; the old paths do not. The link texts are unchanged and still describe their targets.
  • Scope: pass. Two lines in AGENTS.md; no other organization link in AGENTS.md is broken.
  • Routing block: pass. The generated organization routing block is untouched and the pinned check reports it current.
  • Security: not applicable. Documentation links only.

Limits and follow-up

  • The vendored .github/skills/code-review/SKILL.md still links two retired organization instruction files; it is refreshed through its approved revision as a separate change.
  • Any push to this branch voids this review.

@ss-o
ss-o merged commit 8fa9584 into main Oct 6, 2026
16 checks passed
@ss-o
ss-o deleted the feature-717-org-links branch October 6, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant