Repository navigation
docs(agents): repair organization instruction links - #230
Merged
Merged
Conversation
The organization moved the shell dialect dispatcher and the Zsh scripting instruction under .github/instructions/zsh/, so the old links returned 404. Refs z-shell/.github#717
Deploying src with
|
| Latest commit: |
631ca50
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://18738845.zi-src.pages.dev |
| Branch Preview URL: | https://feature-717-org-links.zi-src.pages.dev |
ss-o
commented
Oct 6, 2026
ss-o
left a comment
Member
Author
There was a problem hiding this comment.
Fallback review under ADR-0026: Copilot request not registered on 631ca50
Findings
No actionable findings.
Scope: the complete diff of 631ca50e against base main at 0ec97ac9 (merge base), 1 file, +2/-2. Specification: z-shell/.github#717 and the organization paths at main 020487ffd1bb1c209f317c855fb9a0ea0d107be5.
Note
This is a maintainer-elected fallback self-review after the Copilot request did not register. It is not an independent review or approval to merge.
Review request record
- 2026-10-06T00:38:02Z:
POST /repos/z-shell/src/pulls/230/requested_reviewerswithcopilot-pull-request-reviewer[bot]on head 631ca50 returned success with an emptyrequested_reviewerslist. - After 257 seconds the timeline held no Copilot
review_requestedevent and no review existed. This pull request is not a draft. Review request not registered; cause unconfirmed.
Validation
- Passed, hosted on this head: Linux and macOS ShellCheck, Linux and macOS Installer and Loader, Configured Zsh Lint, Analyze (actions), CodeQL, Org Routing, Installer contract impact, Installer contract detector tests, Cloudflare Pages, Validate Branch Name, Validate Commits, Validate Issue Link, Validate PR Title. Installer consumer evidence was skipped by its own condition.
- Passed, local on this head: the org link scan of every tracked file against organization
main,org-routing.py checkat the pinned organization revision1becebb7,git diff --check. - Signature: the commit is signed and GitHub reports it verified.
- Skipped or unavailable: no shell source changed; the installer and loader suites ran hosted only.
Checklist verdicts and supporting evidence
- Link targets: pass.
.github/instructions/zsh/dialect-selection.instructions.md(title "Shell Dialect Dispatcher",applyTo: **/*.sh) and.github/instructions/zsh/scripting.instructions.mdexist at organizationmain020487ff; the old paths do not. The link texts are unchanged and still describe their targets. - Scope: pass. Two lines in
AGENTS.md; no other organization link inAGENTS.mdis broken. - Routing block: pass. The generated organization routing block is untouched and the pinned check reports it current.
- Security: not applicable. Documentation links only.
Limits and follow-up
- The vendored
.github/skills/code-review/SKILL.mdstill links two retired organization instruction files; it is refreshed through its approved revision as a separate change. - Any push to this branch voids this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.md. refactor(agents): centralize knowledge and native delivery .github#718 moved the shell dialect dispatcher to.github/instructions/zsh/dialect-selection.instructions.mdand the Zsh Scripting Standard to.github/instructions/zsh/scripting.instructions.md, so the old.github/instructions/shell.instructions.mdand.github/instructions/zsh-scripting.instructions.mdlinks return 404.Refs z-shell/.github#717. This repository's guidance stays owned here; only the links change.
Verification
z-shell/.githubmainlink inAGENTS.mdresolves at organizationmain020487ffd1bb1c209f317c855fb9a0ea0d107be5.org-routing.py check --repository z-shell/srcat the pinned organization revision1becebb7b98dab717d82897428afafd792d4fb97: current.trunk checkonAGENTS.md: no issues.git diff --checkpassed..github/skills/code-review/SKILL.mdstill links two retired organization instruction files; it is refreshed through its approved revision, not edited here.Agent handoff
No handoff needed.