Skip to content

installer: success line prints the path with a trailing period #215

Description

@ss-o

Summary

The success line in public/sh/install.sh has its closing period outside the quoted string, so the printed path ends with a dot:

printf '%s\n' "[1;34m▓▒░[0m Successfully installed at [1;32m${ZI_HOME}/${ZI_BIN_DIR_NAME}[0m".

Output today (colour codes stripped):

▓▒░ Successfully installed at /home/user/.local/share/zi/bin.

Why it matters now

The wiki's Agent installation tab (z-shell/wiki#921) tells an agent running -i skip to verify the install by sourcing zi.zsh from the path the installer printed after Successfully installed at. A literal reader copies /bin. and the check fails on a good install.

Proposed fix

Move the period inside the quotes or drop it, in the fresh-clone branch of the checkout phase. One-line change; public/checksum.txt must be regenerated after the commit hook reformats the file.

Follow-up when fixed

The wiki's Agent installation tab (z-shell/wiki#922) tells agents that the fresh-install line currently ends with a period that is not part of the path and links this issue. Remove that sentence from docs/getting_started/01_installation.mdx (the install-only verification paragraph and the copyable instruction block) in the same change or right after it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions