fix(skills): zi-install supports ZI_HOME overrides only with -i skip - #639
Merged
Merged
Conversation
The -a loader block does not propagate ZI_HOME or ZI_BIN_DIR_NAME, so the first shell start would clone a second Zi at the default location (z-shell/src#217). Restrict the overrides to install-only until the installer carries them. Refs #636
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The guidance accurately reflects the linked installer behavior and introduces no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Clarifies Zi installation guidance to prevent duplicate installs when custom paths are used with Loader.
Changes:
- Restricts explicit
ZI_HOMEorZI_BIN_DIR_NAMEoverrides to install-only mode. - Directs agents to stop and explain the Loader limitation tracked in
z-shell/src#217.
| File | Description |
|---|---|
.github/skills/zi-install/SKILL.md |
Documents the custom-path Loader restriction. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ss-o
added a commit
to z-shell/src
that referenced
this pull request
Sep 19, 2026
z-shell/.github#639 restricts explicit ZI_HOME overrides to -i skip until the loader block carries them (src#217); pin the delivery to its squash commit bc2dae03d43216cca93f1f585cb06266c8262ca1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/skills/zi-install/SKILL.md: an explicitZI_HOMEorZI_BIN_DIR_NAMEis supported only with-i skip. The Loader block the installer writes does not carry those values, so with-a loaderthe first shell start would clone a second Zi at the default location; the skill now stops and explains that instead of proceeding (raised by Copilot on the src pilot delivery, chore(agents): install the zi-install skill src#216; the installer defect is install.sh -a loader: an explicit ZI_HOME is not propagated to the loader block, so startup clones a second Zi src#217).Refs #636
Verification
z-shell/srcmainata1ac6d2: the-a loaderblock inMAIN_PROFILEcontains noZI_HOMEorZI_BIN_DIR_NAME, andinit.zshresolves the home from the legacy and XDG locations unlessZI[HOME_DIR]is preset.python3 scripts/validate-agent-policy.pypasses; no manifest change.Instruction impact review (
runbooks/instruction-update.md)Agent handoff
No handoff needed.