Skip to content

fix(skills): make the zi-install loader probe positive #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ss-o merged 1 commit into from
Sep 19, 2026
Merged

fix(skills): make the zi-install loader probe positive #638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/skills/zi-install/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,15 @@ Start a fresh interactive shell, the way the user will, and ask Zi for its help
zsh -ic 'zi -h' >/dev/null && echo 'zi ok'
```

This runs the user's own `.zshrc`, which is the point: it proves the integration works on normal startup. It cannot tell which integration answered, so for Loader the `Loader added` line above is the evidence that the loader block exists; the check below then confirms the loader ran and removed its helpers:
This runs the user's own `.zshrc`, which is the point: it proves the integration works on normal startup. It cannot tell which integration answered, so for Loader the `Loader added` line above is the evidence that the loader block exists, and the probe below is the evidence that the installed loader itself works: it sources the resolved `init.zsh` in a clean shell, requires `zzinit` to be defined by that source, runs it, and requires it to remove itself afterwards. An absent `zzinit` is success only after this probe defined and ran it.

```sh
zsh -ic 'print "zzinit:${+functions[zzinit]}"'
zsh -f -c 'unfunction zzinit _zi_err _zi_fetch _zi_check_stream _zi_setup _zi_source _zi_comps _zi_pmod 2>/dev/null; typeset -gA ZI; if [[ -n ${XDG_CONFIG_HOME:-} && $XDG_CONFIG_HOME == /* ]]; then d="$XDG_CONFIG_HOME/zi"; else d="$HOME/.config/zi"; fi; source "$d/init.zsh" || { print "loader missing"; exit 1 }; (( ${+functions[zzinit]} )) || { print "loader defined no zzinit"; exit 1 }; zzinit || { print "zzinit failed"; exit 1 }; for f in zzinit _zi_err _zi_fetch _zi_check_stream _zi_setup _zi_source _zi_comps _zi_pmod; do (( ${+functions[$f]} )) && { print "helper not removed: $f"; exit 1 }; done; print "loader ok"'
```

Expect `zzinit:0`. `zzinit:1` means the load failed and the helper stayed for a retry; show the user the output of `zsh -ic zzinit`. For `-i skip`, verify only that `zi.zsh` exists beneath the directory the installer printed in its `Successfully installed at <dir>` or `Updating (z-shell/zi) plugin manager at <dir>` line, which honours `~/.zi`, an explicit `ZI_HOME`, and `ZI_BIN_DIR_NAME`; do not assume the XDG default, and leave `.zshrc` untouched.
The probe first removes any loader-owned function that a system `zshenv` might have defined, so every definition it then checks must come from the sourced file; it resolves the configuration home with the installer's rule (an absolute `XDG_CONFIG_HOME`, otherwise `$HOME/.config`) and checks every loader-owned helper, not only `zzinit`. Expect `loader ok`; report any other line verbatim, and for `zzinit failed` show the user the loader's own diagnostic from the same command.

For `-i skip`, verify only that `zi.zsh` exists beneath the directory the installer printed in its `Successfully installed at <dir>` or `Updating (z-shell/zi) plugin manager at <dir>` line, which honours `~/.zi`, an explicit `ZI_HOME`, and `ZI_BIN_DIR_NAME`; do not assume the XDG default, and leave `.zshrc` untouched.

## Report

Expand Down
Loading