refactor(skills): rename new-zsh-plugin to zsh-plugin

[ss-o]

Why

Organization skill names use two conventions at once. code-review, gh-cli, github-issues and zunit-test are domain nouns. create-readme, new-zsh-plugin and review-project-learning are verb-first.

With the direction being one skill per artifact type owning its whole lifecycle, create plus repair plus audit, domain nouns are the correct convention. A skill name is an address; its description frontmatter states the current contract and is what drives selection. Renaming now costs one directory, one skill-* identifier and a handful of path strings. Renaming after the skills are widely referenced costs considerably more.

Decision recorded as decision 8 on #614, which also names zi-package for the package skill and zi-annex for a future one.

A correction worth stating

This rename is not because the skill already does more than create. It does not. Its seven steps are read context, gather inputs, create the layout, write the entry file, write autoload bodies, verify syntax and lifecycle, report. There is no repair path and no audit.

The body is therefore unchanged and the description still says creation only. Growing the scope later needs no second rename, which is the point.

Change

Renamed the directory, the skill-new-zsh-plugin identifier, the frontmatter name, and every path reference across PATTERNS.md, .github/instruction-surfaces.json, .github/instructions/zsh-plugin-standard-aliases.instructions.md, scripts/validate-zsh-standard-policy.py, scripts/test_validate_agent_policy.py and scripts/test_validate_zsh_standard_policy.py.

The only content change anywhere is the single name: line. templates/plugin.plugin.zsh is byte-identical, confirmed with rename detection.

The golden digest

test_repair_2_consumer_parser_outputs_match_frozen_golden covers the parsed output of a fixed path set that includes the renamed skill files, so the rename changes its digest. That is the test working as designed. Its own failure message asks for the diff to be reviewed and the digest replaced in the same commit, which is what happened here.

Verification

Everything the agent-instructions workflow runs, run locally:

Check	Result
test_validate_agent_policy	OK
test_decision_records	OK
test_validate_zsh_standard_policy	OK, 99 tests
validate-zsh-standard-policy.py	passed
validate-agent-policy.py	passed
decision-records.py --check	passed

Follow-up not in this PR

The private meta-workspace generates .agents/skills and .claude/skills from this repository, so those copies still carry the old name until the submodule pointer moves. That regeneration is a separate workspace change after this merges.

Refs #614

[Copilot]

🟢 Approval recommended

The rename is consistently applied and the remaining ADR request is a minor, non-blocking nit.

Pull request overview

Renames the creation-only Zsh plugin skill from new-zsh-plugin to zsh-plugin without changing behavior.

Changes:

• Renamed skill metadata, directory, identifiers, and references.
• Updated routing, documentation, validators, tests, and golden digest.
• Preserved template content.

File summaries

File	Summary
scripts/validate-zsh-standard-policy.py	Updated validator paths.
scripts/test_validate_zsh_standard_policy.py	Updated test paths and digest.
scripts/test_validate_agent_policy.py	Updated manifest expectations.
PATTERNS.md	Updated template references.
.github/skills/zsh-plugin/templates/plugin.plugin.zsh	Relocated unchanged template.
.github/skills/zsh-plugin/SKILL.md	Renamed skill metadata.
.github/instructions/zsh-plugin-standard-aliases.instructions.md	Updated scoped path.
.github/instruction-surfaces.json	Updated skill registration and routing.

Review details

Suppressed comments (1)

.github/instruction-surfaces.json:374

• Please add a proposed ADR for this rename before merging. This changes a public cross-repository skill address, and the issue comment is only the source discussion; the repository's ADR workflow requires decision-level changes to be recorded as a PROPOSED ADR (runbooks/adr.md:22-38, runbooks/instruction-update.md:73-80). Without that durable record, future maintainers lose the rationale for replacing skill-new-zsh-plugin with skill-zsh-plugin.

      "id": "skill-zsh-plugin",
      "path": ".github/skills/zsh-plugin/SKILL.md",

• Files reviewed: 7/8 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.