feat(review): add MCP context profiles and evidence guidance - #611
Merged
Conversation
This was referenced Sep 11, 2026
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Hosted-profile composition and OAuth-evidence wording corrections remain unresolved.
Pull request overview
Adds optional MCP context profiles and evidence guidance for repository reviews.
Changes:
- Defines GitHub and GitHub-plus-documentation context profiles.
- Adds conditional external-context retrieval.
- Documents hosted compatibility boundaries and MCP evidence requirements.
File summaries
| File | Summary |
|---|---|
runbooks/org-review.md |
Adds MCP health-evidence guidance. |
.github/skills/code-review/SKILL.md |
Adds conditional context retrieval rules. |
.github/instructions/mcp-plugins.instructions.md |
Documents hosted MCP profiles and constraints. |
Review details
Suppressed comments (2)
.github/instructions/mcp-plugins.instructions.md:60
- The phrase “interactive OAuth availability proves no hosted compatibility” reverses the evidence rule: an interactive OAuth setup says nothing about whether the hosted review supports that server. Please state that it “does not prove hosted compatibility”; otherwise reviewers may incorrectly record a supported hosted integration as incompatible.
- **Linear:** optional addition only when a linked requirement is unavailable
in GitHub. Evaluate a restricted read-only API-key configuration if supported
by the current server; interactive OAuth availability proves no hosted
compatibility. Do not mirror all tracker context into every review.
.github/instructions/mcp-plugins.instructions.md:55
github-docsis described as documentation lookup only, so a consumer can select it without thegithubbaseline and skip linked requirements, PR context, and CI evidence. The issue and PR scope call for a GitHub-plus-documentation profile; define this profile as thegithubbaseline plus documentation lookup (or explicitly document the composition in the runbook).
- **`github-docs`:** add documentation lookup only for framework, API, or
platform changes that need it, such as wiki Docusaurus or Cloudflare changes.
Prefer official version-matched documentation; Context7 or Cloudflare's
documentation server is optional. Check actual tools and annotations before
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
Agent handoffStatus: Ready for review Current state
Verification
Blockers
Next steps
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviews need linked requirements, CI evidence, and relevant documentation without assuming an installed MCP server was used. This change adds optional GitHub and GitHub-plus-documentation profiles and separates configuration, discovery, and invocation evidence in the existing health procedure.
The portable review skill now selects external context only when relevant. Hosted compatibility guidance requires explicit tool allowlists and readOnlyHint annotations, distinguishes interactive OAuth from supported hosted authentication, and preserves repository access boundaries. No custom server, dependency, credential, or settings change is included.
Closes #610. Refs #606 for the coordinated rollout. Wiki and zsh-fancy-completions will receive native installations pinned to this published source revision. Hosted settings and actual use remain unverified pending configuration and session evidence.
Instruction-impact review
Validation
88 public agent-policy tests, the public policy and Zsh-standard validators, skill validation, and relevant formatting/whitespace checks passed. Independent review verified the conditional context and authority boundaries.
A public Cloudflare documentation-server initialization preflight returned HTTP 403. Its upstream source declares a read-only search tool, but source inspection does not establish hosted discovery or invocation. Pilot activation therefore remains pending.