chore: ignore generated Python cache artifacts - #609
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved scope, test-assertion, and issue-closure concerns remain.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 2
- Review effort level: Lite
| grep -q 'git diff-tree --quiet --no-commit-id -r "\$sha"' "$WORKFLOW" || | ||
| fail "empty commits are not skipped before subject lint" |
| if git diff-tree --quiet --no-commit-id -r "$sha"; then | ||
| echo "Skipping empty commit (${sha:0:7})" | ||
| continue | ||
| fi |
There was a problem hiding this comment.
🟡 Changes recommended
The empty-commit exemption is too broad, and the issue-closing reference should be corrected.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
| if git diff-tree --quiet --no-commit-id -r "$sha"; then | ||
| echo "Skipping empty commit (${sha:0:7})" | ||
| continue | ||
| fi |
There was a problem hiding this comment.
Addressed in ce7f7c6 by removing the empty-commit exemption and restoring the previous commit-subject validation behavior.
Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>
Fixed in ce7f7c6 by removing the empty-commit exemption and restoring strict Conventional Commit subject validation for non-merge commits. |
The review-skill readiness policy and canonical skill for repository-health evaluation are already present on
main. This follow-up keeps that rollout clean by preventing Python validator/test cache output from appearing as repository changes in subsequent review-readiness work.Scope
Change
__pycache__/to the root.gitignore..pycfiles generated byscripts/validate-agent-policy.pyand related unittest runs from being staged into PRs.Why this matters