Skip to content

decision: amend ADR-0026 for maintainer-elected fallback reviews #664

Description

@ss-o

Problem

ADR-0026 (decision 3) allows the fallback review only after a Copilot request "is not registered", and makes the opening line Fallback review under ADR-0026: Copilot request not registered on <sha> part of that procedure. It does not cover a maintainer choosing the fallback up front to save review allowance.

On 2026-09-26 the maintainer chose exactly that for the commit-lint caller wave: fallback reviews on the ten class 2-4 pull requests, a Copilot request only on the two class 1 ones. No Copilot request was made on the ten, but each review opens with the ADR marker, so the record on these pull requests says a request failed when none was made:

z-shell/F-Sy-H#192, z-shell/z-a-default-ice#12, z-shell/z-a-eval#11, z-shell/z-a-meta-plugins#102, z-shell/zd#125, z-shell/zpmod#114, z-shell/zsh#23, z-shell/zsh-eza#125, z-shell/zsh-fancy-completions#68, z-shell/zunit#27.

Each now carries a correction comment.

A second gap showed up at the same time. Decision 3 treats every unregistered request as "blocked on quota". On z-shell/wiki#926 and z-shell/src#228, POST requested_reviewers with copilot-pull-request-reviewer[bot] returned 201, and no review_requested event followed. Quota exhaustion is one explanation, but an API or reviewer-identifier problem looks identical, and the ADR gives no way to tell them apart.

Proposal

  1. Add a maintainer-elected fallback for classes 2-4 with its own marker line, for example Fallback review under ADR-0026: maintainer elected, no Copilot request on <sha>.
  2. In decision 3, state how to confirm quota before declaring it: the request path that is known to register, and what the requester's allowance page shows.
  3. Say whether the ten reviews above should be amended in place or left with their correction comments.

Relates to #642.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:metaOrganization-wide policy, templates, or meta-repo work.type:maintenanceNon-feature maintenance, cleanup, or org work.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions