Conversation
Accept an inclusive [months] from/to table alongside the existing int list, omit (full year), and legacy month = N. Co-authored-by: Joseph Chiocchi <joe@yolk.cc>
Contributor
|
Drafts cannot be merged. Remove DO NOT MERGE from the title, then click Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look-later draft — do not merge. Parks an inclusive closed-table form for pressed months next to the existing int list.
or inline
months = { from = 1, to = 3 }._parse_monthsexpands the table totuple[int, ...]at parse time. No new Spec type.1..12months = [1, 2, 3]stays a literal member list (a 2-element list is not a span)month = Nstill maps to(N,)fromandtorequired ints,1 <= from <= to <= 12, unknown keys fail (unknown months key …)"1..12"strings, nostep, no multi-spanexamples/nomad.tomlkeeps the explicit list and notes the table equivalent in a comment.