Make Docker Server bootstrap recoverable - #167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.envcreation with a recoverable bootstrap state machine:AssetsPrepared -> SecretCommitted -> ContainerStarted -> ServerHealthy -> PairingReady.envand the installation receipt via 0600 temporary files, durable sync, and atomic renamestatus,resume, and secret-preservingrollback; reconcile the crash window where.envcommitted but the receipt update did not/openapi.jsonbefore success or pairing-code creation.webcodex-bootstrap.receiptwithout storing the token.envand the named data volume on post-secret rollback so a partially initialized Server cannot be locked out by token regenerationFailure/recovery coverage
The bootstrap tests now inject and verify pull failure, missing source overlay/Dockerfile, busy port,
docker compose upfailure, uncertain up outcome with a surviving container, health failure, pairing failure, env sync failure, receipt sync failure before and after env commit, env fingerprint drift, resume, rollback, unmanaged legacy.env, and strict origin parsing (DNS/IPv4/bracketed IPv6/ports/injection cases).Validation
python3 -m unittest scripts.tests.test_server_docker_bootstrap— 20 passedbash scripts/test_python_tooling.sh— 78 passed; all 19 Python files syntax-checkedsh -n deploy/docker/bootstrap.shsh -nand contains only the canonical runtime URL validatorpython3 scripts/check_markdown_links.py— 44 files, 263 local links, 0 missinggit diff --checkThis is intentionally limited to Docker Server bootstrap/install recovery and its release asset/tests/docs; it does not alter Server auth/connect semantics or the published immutable v0.3.8 assets.