Fix for the race condition being created when two threads were simultaneously doing refresh#8
Merged
Merged
Conversation
ashetkar
reviewed
Nov 26, 2025
ashetkar
reviewed
Dec 5, 2025
ashetkar
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Refresh() function initialHosts list is being read by one thread while the other thread might be removing an unreachable host from it, mutating the list.
This is creating the following race condition and throwing the error:
This fix sets up a lock before needsRefresh() is called so that only one thread actually does the refresh, the other threads can move past this step.
Testing
Tested it with a multithreaded application that was long running and read from the database. A shell script was used to periodically down and restart the server nodes.