Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,16 +75,6 @@ jobs:
if: github.event_name == 'push'
run: ./gradlew :app:assembleRelease

- name: Generate coverage report
run: ./gradlew :app:jacocoTestReport

- name: Upload coverage report
uses: actions/upload-artifact@v4
with:
name: jacoco-coverage-report
path: app/build/reports/jacoco/
if-no-files-found: error

- name: Upload debug APK
uses: actions/upload-artifact@v4
with:
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/i18n-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ on:
pull_request:
paths:
- "app/src/main/res/values*/strings.xml"
# Without this, a change to the check itself never runs the check.
- ".github/workflows/i18n-check.yml"

jobs:
check-translations:
Expand All @@ -26,7 +28,7 @@ jobs:

if [ -n "$missing" ]; then
count=$(echo "$missing" | wc -l | tr -d ' ')
echo "::warning file=$file::[$lang] Missing $count translation(s): $(echo $missing | tr '\n' ' ')"
echo "::error file=$file::[$lang] Missing $count translation(s): $(echo $missing | tr '\n' ' ')"
MISSING_FOUND=1
fi

Expand All @@ -38,7 +40,9 @@ jobs:

if [ "$MISSING_FOUND" -eq 1 ]; then
echo ""
echo "Some translations are incomplete. See warnings above."
else
echo "All translations are complete."
echo "Some translations are incomplete. See the errors above."
echo "Add the missing keys to every values-*/strings.xml, or remove them from the source."
exit 1
fi

echo "All translations are complete."
3 changes: 0 additions & 3 deletions .last-release

This file was deleted.

39 changes: 0 additions & 39 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ plugins {
id("org.jetbrains.kotlin.plugin.serialization")
id("com.google.devtools.ksp")
id("androidx.baselineprofile")
id("jacoco")
}

val repoRoot = rootProject.projectDir
Expand Down Expand Up @@ -242,41 +241,3 @@ dependencies {
debugImplementation("androidx.compose.ui:ui-tooling")
debugImplementation("androidx.compose.ui:ui-test-manifest")
}

// The base jacoco plugin only wires a report task to the JVM `test` task, which an Android module
// does not have — so `:app:jacocoTestReport` did not exist and CI's coverage step failed outright.
tasks.register<JacocoReport>("jacocoTestReport") {
dependsOn("testDebugUnitTest")
group = "verification"
description = "Generates a coverage report for the debug unit tests."

reports {
html.required.set(true)
xml.required.set(true)
}

val generated =
listOf(
"**/R.class",
"**/R$*.class",
"**/BuildConfig.*",
"**/Manifest*.*",
"**/*Test*.*",
"**/*_Factory*.*",
"**/*Composable*.*",
"**/*\$\$serializer.*",
)
classDirectories.setFrom(
fileTree(layout.buildDirectory.dir("tmp/kotlin-classes/debug")) { exclude(generated) },
)
sourceDirectories.setFrom(files("src/main/java"))
// Only the unit test coverage directories, never the whole build directory: scanning that
// makes Gradle treat every other task's output as an undeclared input of this one, which fails
// the build as soon as a release variant is assembled in the same invocation.
executionData.setFrom(
fileTree(layout.buildDirectory.dir("jacoco")) { include("*.exec") },
fileTree(layout.buildDirectory.dir("outputs/unit_test_code_coverage")) {
include("**/*.exec")
},
)
}
Loading