Fix chat composer overlapping nav bar, remove focus mode toggle#82
Merged
Merged
Conversation
- The bottom mode/auto-accept/context chips row had no navigation-bar inset handling, so it could render partially behind the system navigation bar. Add navigationBarsPadding() alongside the existing imePadding(). - Remove the focus-mode fullscreen toggle FAB: tapping it hid the chat title, drawer button, and new-chat button with no way back other than tapping the same spot again, which was confusing and unwanted.
yuga-hashimoto
force-pushed
the
claude/mobile-menu-button-layout-1w4pjh
branch
from
July 25, 2026 05:26
c5159c4 to
9e3d3f0
Compare
yuga-hashimoto
marked this pull request as ready for review
July 25, 2026 05:36
Contributor
API 34 emulator screenshot failureDiagnostic logs were uploaded as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatComposerinsideChatHomeScreen.kt) only hadimePadding(), no navigation-bar inset handling. On devices/OS states that draw content edge-to-edge, this let the row render partially behind the system navigation bar (matches the reported screenshots: the "build" mode chip and neighboring controls sitting right against/under the 3-button nav bar). AddednavigationBarsPadding()alongside the existingimePadding().FocusModeOverlay, top-right corner button). Tapping it hid the chat title, drawer (hamburger) button, and new-chat ("+") button with no other way to bring them back — confusing, unrequested behavior. DeletedFocusModeOverlay.ktand its wiring (focusModestate, theAnimatedVisibilitywrapper around the top app bar, and the FAB call) since nothing else referenced it.Test plan
./gradlew :app:compileDebugKotlin(could not run in this sandbox — no Android SDK available; changes only add a standard, stableandroidx.compose.foundation.layoutmodifier and remove now-dead code/state)