Skip to content

Add user creation form with validation and update README - #6

Merged
yudc13 merged 5 commits into
devfrom
main
Apr 8, 2026
Merged

Add user creation form with validation and update README#6
yudc13 merged 5 commits into
devfrom
main

Conversation

@yudc13

@yudc13 yudc13 commented Apr 8, 2026

Copy link
Copy Markdown
Owner

No description provided.

@yudc13
yudc13 merged commit c6cbfc2 into dev Apr 8, 2026
1 check failed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 196d83b99d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/api/users/route.ts
Comment on lines +27 to +31
return apiOk(
{
user: {
id: crypto.randomUUID(),
username: parsed.data.username,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Persist the user record before returning 201

POST /api/users currently validates input and immediately returns success with crypto.randomUUID(), but there is no call to Clerk or any DB/repository write in this handler. In practice, the form shows a successful creation while no real account exists, so downstream flows that rely on the returned user.id will point to a non-existent user. This should perform an actual create operation (or surface a failure) before returning apiOk.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants