Make RPC auto-review fail closed when unmanned - #31
Open
love-lena wants to merge 1 commit into
Open
Conversation
love-lena
force-pushed
the
rpc-unmanned-fail-closed
branch
from
June 29, 2026 20:46
cce36d3 to
a1650e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpt5.5 suggested and wrote this, consider it slop draft.
- Lena
Make RPC auto-review fail closed when unmanned
Summary
.agents/pi-auto.jsonin RPC unless the project is trusted--approve/ saved project trust) to continue using per-project settingsWhy
Pi RPC mode exposes extension UI through JSON, so
ctx.hasUIis true even when no human is attached. The previous fallback paths could block indefinitely waiting forextension_ui_response. For unmanned RPC, the safer behavior is to fail closed.Per-project pi-auto config can also weaken a global safety posture. In RPC, only trusted projects should be able to contribute that layer.
Verification
npm run typechecknpm test