Repository navigation
MP-122: Статус merged в свежей базе mypi - #89
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
A database created by
pnpm bootstraphad nomergedstatus, somp-task status <KEY> mergedfailed and/shipleft tasks inreview. The fresh seed now includesmerged(non-terminal); existing databases are not changed (schema stays 15, nodb init).Plan: https://draft.yokeloop.com/artifacts/mp-122-merged-mypi-r8241gm5
Steps
('merged', 0)last in001-initial.sql(id 11; ids 1–10 unchanged).test/fast/database.test.ts: fresh status list expectsmerged; the no-op-on-current-database part now holdsmergedwith another id.review → merged → done.### Fixedentry; older databases add the status once withmypi status add merged.Checks
mise exec -- pnpm build— exit 0mise exec -- pnpm verify— exit 0 (fast 237/237, boundary 67/67)Stand acceptance (disposable,
XDG_STATE_HOMEunder a scratch dir)y) →status listends with{"id":11,"code":"merged","isTerminal":false}.review → merged(exit 0,task listshowsmerged) →done(exit 0).customadded andpausedrenamedhold):status listandtask listbefore and afterdb init—diffempty;status liststill opens it.Review
task-reviewer: approved, no findings.
Note: commit 027515f alone leaves the fast suite red until 6642bd0 updates the expectation (separate plan steps).
🤖 Generated with Claude Code