agents: preserve indexed Pydantic text replacements - #966
Draft
yisding wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #961 restored initial PydanticAI
TextPartcontent, but the bridge stillnormalized every part start as an append-only
text_deltaand discardedPartStartEvent.index. PydanticAI may emit another start for the same index asa replacement, so consumers could retain stale text or append duplicate text.
What changed
AgentBridgeEventwith indexed text events and atext_replacekindsame-index starts and graph-local index namespaces
and voice consumers so transcripts and history preserve replacement semantics
AgentDeltaand journal recordsis admitted, cancel and clear stale playback and suppress further TTS for the
turn while allowing the corrected transcript and history to complete
buffering, playback cutoff, graph streams, and consumer history
Impact
Ordinary unindexed
text_deltastreams remain append-only. Indexed bridges mustuse indexed deltas consistently within a turn. A divergent replacement after
TTS admission fails closed instead of replaying corrected text over speech the
caller may already have heard.
Verification
368 passedacross the focused bridge, PydanticAI, stage, session consumer,event, and lifecycle suites
just guard-contracts(218 passed).venv/bin/ruff check src tests.venv/bin/ruff format --check src tests.venv/bin/mypy src/easycat(289 source files)Follow-up to #961.