agents: own Llama cleanup tasks - #937
Merged
yisding merged 1 commit intoAug 7, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yisding
marked this pull request as ready for review
August 7, 2026 02:45
yisding
force-pushed
the
agent/ws26-llama-cleanup-scope
branch
from
August 7, 2026 03:20
25ee20e to
fd67749
Compare
yisding
force-pushed
the
agent/ws26-llama-cleanup-scope
branch
from
August 7, 2026 03:49
fd67749 to
6495437
Compare
yisding
merged commit Aug 7, 2026
bc36a53
into
agent/ws25-voice-server-listener-scope
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LlamaAgentsBridgekept synchronous-reset cleanup in a hand-managed task set and created bounded handler-cancel work withasyncio.ensure_future. The former duplicated scope bookkeeping; the latter could survive its deadline without a bridge-local owner.Changes
aclose()wait past their deadlineaclose()Why / impact
Reset and cancellation behavior stay best-effort and keep the same timeout. Cleanup work is now explicitly attached to the bridge, while the two scopes preserve the important distinction between reset work that
aclose()must join and cancellation work that may outlive the bounded wait.Checks
.venv/bin/python -m pytest tests/integrations/agents/test_llama_agents_bridge_cancellation.py tests/integrations/agents/test_llama_agents_bridge_local.py tests/integrations/agents/test_llama_agents_bridge_remote.py -q(45 passed).venv/bin/python -m pytest tests/integrations/agents -k 'llama or lifecycle_credential_free' -q(66 passed, 2 skipped).venv/bin/python -m pytest tests/ratchets/test_source_inventory.py tests/ratchets/test_teardown_budget_inventory.py -q(16 passed)