server: require owned timed awaits - #934
Merged
yisding merged 1 commit intoAug 7, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yisding
marked this pull request as ready for review
August 7, 2026 02:45
yisding
force-pushed
the
agent/ws25-safe-await-owned-input
branch
from
August 7, 2026 03:15
1cf793a to
6b9902d
Compare
yisding
force-pushed
the
agent/ws25-safe-await-owned-input
branch
from
August 7, 2026 03:48
6b9902d to
8a189f3
Compare
yisding
merged commit Aug 7, 2026
bc36a53
into
agent/ws25-voice-server-listener-scope
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_safe_awaitunconditionally passed every awaitable throughasyncio.ensure_future, even when no timeout was requested. That hid a raw task start inside a best-effort reap helper and allowed timed callers to hand it bare, otherwise-unowned cleanup coroutines.Changes
FutureorTaskWhy / impact
The helper no longer creates hidden work. Timed cleanup must establish ownership before waiting, while ordinary best-effort cleanup keeps its existing exception and cancellation behavior.
Checks
.venv/bin/python -m pytest tests/server/test_capacity_gate_drain.py tests/server/test_websocket_runtime_drain.py -q(81 passed).venv/bin/python -m pytest tests/ratchets/test_source_inventory.py -q(9 passed).venv/bin/ruff check src/easycat/server/transports.py tests/server/test_capacity_gate_drain.py.venv/bin/ruff format --check src/easycat/server/transports.py tests/server/test_capacity_gate_drain.py.venv/bin/mypy src/easycat/server/transports.py