Skip to content

server: own final session sweep - #930

Merged
yisding merged 1 commit into
agent/ws25-voice-server-listener-scopefrom
agent/ws25-voice-server-sweep-scope
Aug 7, 2026
Merged

server: own final session sweep#930
yisding merged 1 commit into
agent/ws25-voice-server-listener-scopefrom
agent/ws25-voice-server-sweep-scope

Conversation

@yisding

@yisding yisding commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Problem

VoiceServer's final forced SessionManager.stop_all() sweep was the module's last raw task spawn. Its hard deadline may return while a cancellation-resistant Session teardown is still unwinding, leaving that survivor anonymous even though restart is correctly fenced.

Changes

  • run the final hard sweep through a dedicated RuntimeTaskScope
  • assign the stable task name easycat-voice-server-session-sweep
  • preserve aggregate stop reports, hard-timeout error recording, retry fences, and cleanup ordering
  • verify completed failed sweeps leave the scope and retain Session state for retry
  • add a cancellation-resistant timeout regression proving the named sweep remains owned until settlement
  • reduce the reviewed raw-task-spawn inventory from 30 to 29

Why / impact

The final Session sweep now remains attached to VoiceServer's explicit cleanup owner across a hard-timeout return. Retry behavior stays unchanged, and the module no longer contains grandfathered raw spawns.

Root cause

The hard sweep relied on the legacy hard-timeout background ledger and predated WS2.5's named task ownership.

Checks

  • focused failed/timeout sweep and source-inventory tests — 12 passed across focused runs
  • full VoiceServer lifecycle file outside the sandbox — 25 passed / 4 skipped
  • Ruff on changed Python files — passed
  • mypy on voice_server.py — passed
  • pre-commit hooks — passed

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b7d85357-b17a-4136-963a-05c109e0609f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yisding
yisding marked this pull request as ready for review August 7, 2026 02:45
@yisding
yisding force-pushed the agent/ws25-voice-server-sweep-scope branch from 168d501 to 3546245 Compare August 7, 2026 03:13
@yisding
yisding force-pushed the agent/ws25-voice-server-sweep-scope branch from 3546245 to 5ef3bb5 Compare August 7, 2026 03:48
@yisding
yisding merged commit bc36a53 into agent/ws25-voice-server-listener-scope Aug 7, 2026
2 checks passed
@yisding
yisding deleted the agent/ws25-voice-server-sweep-scope branch August 7, 2026 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant