server: own listener cleanup tasks - #929
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fbeba9db3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fbeba9d to
ba37a59
Compare
ba37a59 to
56e3c3a
Compare
…rized-bind server: authorize voice websocket bind
twilio: replace connection generation
Problem
VoiceServer retained cancellation-resistant HTTP site/runner cleanup operations in a stage-keyed dictionary, but created them with raw
asyncio.ensure_future(). The retry ledger prevented duplicate cleanup calls, yet the surviving task itself remained outside named runtime ownership.Changes
RuntimeTaskScopeeasycat-voice-server-listener-cleanup-http-site-stopWhy / impact
A site or runner cleanup that survives its hard deadline now has one explicit task owner as well as a stable retry key. Later
stop()calls still await the original operation instead of racing a second listener teardown.Root cause
The retry-safe listener ledger was added before the shared runtime task-scope abstraction and had not yet been migrated in WS2.5.
Checks
voice_server.py— passed