server: report WebRTC cleanup failures

[yisding]

Problem

WebRTC route shutdown spawned forced per-session finalizers with raw asyncio.create_task() and discarded every gather(return_exceptions=True) result. Expected cancellation of peer-close waiters and genuine forced-finalizer failures were indistinguishable, so teardown defects could disappear silently.

Changes

• run forced cleanup finalizers in a separate named RuntimeTaskScope
• preserve the hard-timeout behavior and the existing concurrent cleanup fan-out
• pair gathered results with task handles and names
• suppress only CancelledError from cleanup waiters explicitly cancelled by shutdown
• log unexpected exceptions with the exact task identity
• add regression coverage for both expected cancellation and a failing forced finalizer
• reduce the reviewed raw-task-spawn inventory from 34 to 33

Why / impact

Normal teardown cancellation stays quiet, while a real cleanup failure is now observable as easycat-webrtc-force-cleanup-<key>. The result policy no longer hides broken Session/capacity finalization.

Root cause

The original shutdown code used return_exceptions=True solely to keep one cleanup failure from short-circuiting siblings, but never inspected the returned exception values.

Checks

• full capacity-gate/source-inventory slice — 72 passed
• focused result-policy regression — 2 passed
• Ruff on changed Python files — passed
• mypy on webrtc_routes.py — passed
• pre-commit hooks — passed

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 12f5e0de-db99-4d8e-a061-7668fce8cfba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 616c69a0a3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Report forced-finalizer failures that settle after the timeout

When a forced finalizer resists or defers cancellation past timeout_s and later raises, _await_with_hard_timeout returns False, this assigns None, and _report_cleanup_results is permanently skipped. The task remains scope-owned, but RuntimeTaskScope._on_done logs failures only at DEBUG, so the genuine cleanup failure this change intends to expose is still absent from normal production logs; attach the error-reporting policy to late task completion as well.

Useful? React with 👍 / 👎.