runtime: expose retryable finalizer runs - #883
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61890a2c55
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
61890a2 to
cb6cd68
Compare
Problem
Some resource owners need concurrent callers to share one retryable cleanup transaction before the Session root itself begins closing. Modeling that transaction as an ordinary task would fail after task admission closes and would duplicate the finalizer's ownership semantics.
Changes
RuntimeScope.run_finalizer(name)for explicit registered-finalizer invocationValidation
just check— 8526 passed, 308 skipped