tts: scope persistent socket readers - #881
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cb77a3815
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
9cb77a3 to
fa10ac7
Compare
Problem
The persistent multi-context TTS socket reader is still spawned outside lifecycle ownership. It also cannot be drained at TTS scheduler finalization because the shared socket intentionally remains warm until provider close.
Changes
tts-receivefinish cohort in both stop modestts-receiveafteraudio-providers-closein the complete Session.stop phase mapValidation
just check— 8524 passed, 308 skipped