Skip to content

stt: scope websocket receive loops - #879

Merged
yisding merged 2 commits into
agent/ws2-openai-realtime-close-scopefrom
agent/ws2-stt-receive-scope
Aug 7, 2026
Merged

stt: scope websocket receive loops#879
yisding merged 2 commits into
agent/ws2-openai-realtime-close-scopefrom
agent/ws2-stt-receive-scope

Conversation

@yisding

@yisding yisding commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Problem

WebSocket STT receive loops still use a raw task spawn. They cannot share the earlier stt-runtime cancel phase because the receive loop must remain live until provider finalization sends its control frame and closes or releases the socket.

Changes

  • own receive loops under the attached STT provider RuntimeScope
  • add a distinct stt-receive finish cohort ordered after stt-finalize
  • preserve the existing provider-local close timeout and cancellation fallback
  • document the new phase in the complete Session.stop mapping
  • remove the final raw task spawn from WebSocketSTTBase's connect path

Validation

  • just check — 8522 passed, 308 skipped
  • focused WebSocket STT matrix — 244 passed, 3 deselected
  • focused Ruff and mypy checks
  • source and teardown-budget ratchets

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d8347314-89f9-4730-b667-dfdf8b138e0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1fdb5a77a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/easycat/stt/websocket_base.py
@yisding
yisding force-pushed the agent/ws2-stt-receive-scope branch from 1fdb5a7 to 22dea37 Compare August 5, 2026 16:42
@yisding
yisding merged commit 9ed4d4e into agent/ws2-session-stop-mapping Aug 7, 2026
2 checks passed
@yisding
yisding deleted the agent/ws2-stt-receive-scope branch August 7, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant