stt: scope interruptible audio sends - #876
Open
yisding wants to merge 1 commit into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
yisding
force-pushed
the
agent/ws2-stt-audio-send-scope
branch
from
August 5, 2026 16:42
10fbe1f to
b1c0a09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Interruptible STT audio writes are still spawned directly and tracked only by a provider-local task handle, so Session teardown cannot see that work in its runtime tree.
Changes
RuntimeScopeBindableprovider capabilitystt-runtimecancellation cohortgather(return_exceptions=True)site from the source ratchetWebSocket receive-loop migration remains separate because that loop must stay live through provider finalization; folding it into this cohort without its finalizer ordering would lose final transcripts.
Validation
just check— 8521 passed, 308 skipped