Skip to content

stt: scope interruptible audio sends - #876

Open
yisding wants to merge 1 commit into
agent/ws2-stt-runtime-scopefrom
agent/ws2-stt-audio-send-scope
Open

stt: scope interruptible audio sends#876
yisding wants to merge 1 commit into
agent/ws2-stt-runtime-scopefrom
agent/ws2-stt-audio-send-scope

Conversation

@yisding

@yisding yisding commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Problem

Interruptible STT audio writes are still spawned directly and tracked only by a provider-local task handle, so Session teardown cannot see that work in its runtime tree.

Changes

  • add a typed RuntimeScopeBindable provider capability
  • attach built-in STT provider runtime work beneath the Session root
  • place interruptible audio writes in the mapped stt-runtime cancellation cohort
  • preserve the existing child-vs-caller cancellation discriminator and retained-send retry behavior
  • close idle local scopes for standalone provider use
  • remove one raw task spawn and one gather(return_exceptions=True) site from the source ratchet

WebSocket receive-loop migration remains separate because that loop must stay live through provider finalization; folding it into this cohort without its finalizer ordering would lose final transcripts.

Validation

  • just check — 8521 passed, 308 skipped
  • focused STT/Session lifecycle suite — 95 passed
  • focused Ruff and mypy checks
  • source and teardown-budget ratchets

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fb698be4-4334-4922-b023-41eccd6925a0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yisding
yisding force-pushed the agent/ws2-stt-audio-send-scope branch from 10fbe1f to b1c0a09 Compare August 5, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant