Skip to content

providers: scope error event emissions - #874

Merged
yisding merged 3 commits into
agent/ws2-session-stop-mappingfrom
agent/ws2-provider-error-emitter-scope
Aug 7, 2026
Merged

providers: scope error event emissions#874
yisding merged 3 commits into
agent/ws2-session-stop-mappingfrom
agent/ws2-provider-error-emitter-scope

Conversation

@yisding

@yisding yisding commented Aug 5, 2026

Copy link
Copy Markdown
Owner

Problem

Provider error publication still owns fire-and-forget tasks through a local set and drains them with gather(return_exceptions=True). That ownership is invisible to the Session runtime tree, and STTBase reaches across implementations with a duck-typed getattr drain.

Changes

  • attach STT/TTS ProviderErrorEmitter work to named Session RuntimeScope children
  • use a closing local scope for standalone provider usage
  • add an explicit provider-error drain hook and remove the duck-typed STT reach-across
  • add RuntimeScope.drain(..., suppress_errors=True) to preserve the reviewed log-and-drop emission policy without cancelling sibling work
  • split the dependency-free credential predicate into a leaf module to preserve import layering
  • shrink the source ratchet by one raw task spawn and one gather(return_exceptions=True) site

Validation

  • just check — 8519 passed, 308 skipped
  • focused provider/runtime/Session/credential suite — 271 passed, 2 deselected
  • source and teardown-budget ratchets
  • one unrelated telephony 200 ms timing test expired on the first parallel full-suite run; the exact node passed in isolation, and the complete just check rerun passed

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 24e3b1f9-1991-4c9a-b9d8-baa716e92704

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a060688495

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/easycat/session/_session.py Outdated
@yisding
yisding force-pushed the agent/ws2-provider-error-emitter-scope branch from cd7334e to 8e58a20 Compare August 5, 2026 16:42
@yisding
yisding merged commit 9ed4d4e into agent/ws2-session-stop-mapping Aug 7, 2026
2 checks passed
@yisding
yisding deleted the agent/ws2-provider-error-emitter-scope branch August 7, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant