providers: scope error event emissions - #874
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a060688495
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cd7334e to
8e58a20
Compare
Problem
Provider error publication still owns fire-and-forget tasks through a local set and drains them with
gather(return_exceptions=True). That ownership is invisible to the Session runtime tree, and STTBase reaches across implementations with a duck-typedgetattrdrain.Changes
ProviderErrorEmitterwork to named Session RuntimeScope childrenRuntimeScope.drain(..., suppress_errors=True)to preserve the reviewed log-and-drop emission policy without cancelling sibling workgather(return_exceptions=True)siteValidation
just check— 8519 passed, 308 skippedjust checkrerun passed