Link/cut tree for internal DomSlot for faster traversal - #4189
Open
WorldSEnder wants to merge 18 commits into
Open
Link/cut tree for internal DomSlot for faster traversal#4189WorldSEnder wants to merge 18 commits into
WorldSEnder wants to merge 18 commits into
Conversation
WorldSEnder
changed the title
|
Visit the preview URL for this PR (updated for commit ccea9a3): https://yew-rs-api--pr4189-cut-link-dom-positio-xow3l9s4.web.app (expires Thu, 27 Aug 2026 12:55:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
This prepares a change in the structure to a link/cut tree. We want clear ownership rules, where each DynamicDomSlot owns an internal node, the clones are only handles for it, but should not keep the slot alive.
WorldSEnder
force-pushed
the
cut-link-dom-position
branch
from
July 22, 2026 10:38
d94d1b5 to
7e99014
Compare
Size ComparisonDetails
|
ty clippy
Member
Author
|
@Madoshakalaka the cut tree forest impl is a bit dense. Apart from that, I am not so sure the code size costs are worth the performance. It should definitely save a bit of time in deeply nested things and I want to perf check this before a final judgement too. Thoughts? |
Member
|
wut, will have a look tomorrow! |
Member
Author
|
Removing the slab and going back to |
instead of a slab, data is contained in an Rcs for each DynamicDomSlot
Member
Author
|
@Madoshakalaka 1kB of overhead cut by going back to "just" an I have a (silly) worst-case example benchmark where this gains quite a bit of performance, not included in the PR though. I will run the benchmarks in the repo locally, since the CI fails to build them. |
repo currently contains a peerDependency on esLint that can't be fulfilled. Accept esLint ^10 with --legacy-peer-deps
Member
Author
|
The benchmark numbers are looking incredibly good on CI, I can't reproduce this on my laptop. |
WorldSEnder
marked this pull request as ready for review
August 20, 2026 13:20
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This prepares a change in the structure to a link/cut tree. We want clear ownership rules, where each DynamicDomSlot owns an internal node, the clones are only handles for it, but should not keep the slot alive.
Checklist