Skip to content

Add ACT4 nightly compliance test workflow#631

Merged
gabrielbosio merged 24 commits into
mainfrom
act4-nightly
Jun 2, 2026
Merged

Add ACT4 nightly compliance test workflow#631
gabrielbosio merged 24 commits into
mainfrom
act4-nightly

Conversation

@gabrielbosio
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread .github/workflows/act4-nightly.yml Outdated
Comment thread .github/workflows/act4-nightly.yml
Comment thread .github/workflows/act4-nightly.yml
Comment thread .github/workflows/act4-nightly.yml
@yetanotherco yetanotherco deleted a comment from claude Bot May 28, 2026
@yetanotherco yetanotherco deleted a comment from github-actions Bot May 28, 2026
@gabrielbosio
Copy link
Copy Markdown
Collaborator Author

/claude /codex

Comment thread .github/workflows/act4-nightly.yml Outdated
Comment thread .github/workflows/act4-nightly.yml Outdated
@gabrielbosio gabrielbosio marked this pull request as ready for review May 28, 2026 19:54
Comment thread .github/workflows/act4-nightly.yml Outdated
Comment thread .github/workflows/act4-nightly.yml Outdated
Comment thread .github/workflows/act4-nightly.yml Outdated
@yetanotherco yetanotherco deleted a comment from claude Bot May 28, 2026
@yetanotherco yetanotherco deleted a comment from github-actions Bot May 28, 2026
@gabrielbosio
Copy link
Copy Markdown
Collaborator Author

/claude /codex

@github-actions
Copy link
Copy Markdown

Codex Code Review

No findings.

The PR only adds .github/workflows/act4-nightly.yml; I did not see concrete security, correctness, or significant performance issues in the changed workflow. No Rust/VM code changed in this diff.

Comment thread .github/workflows/act4-nightly.yml Outdated
@yetanotherco yetanotherco deleted a comment from claude Bot May 28, 2026
gabrielbosio and others added 8 commits May 28, 2026 17:37
The test job was gated on the "Bench Vs Nightly" run concluding with
success. Since the workflow_run trigger is only used to serialize on the
shared bench runner (not a real dependency), a failed or timed-out
benchmark silently skipped ACT4 for the night and filed no issue.

Run on any benchmark conclusion, skipping only 'cancelled' (a newer bench
run is already inbound) and 'skipped' (nothing ran).
A GitHub issue is easy to miss. Post nightly ACT4 failures to the same
Slack channel the nightly benchmark already reports to, reusing
BENCH_VS_SLACK_WEBHOOK (and the _TEST variant for manual runs so smoke
tests don't ping the real channel).

The report job no longer needs issues: write. The payload is built with
jq so the commit SHA and result summary are safely encoded, and the step
skips gracefully when the webhook secret is absent.
@gabrielbosio gabrielbosio added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit 3dfc932 Jun 2, 2026
12 checks passed
@gabrielbosio gabrielbosio deleted the act4-nightly branch June 2, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants