remove unnecessary unsafe componentWillReceiveProps - #30
Open
maherzaidoune wants to merge 4 commits into
Open
Conversation
Owner
|
Hi @maherzaidoune Do you want to write testcases for this? |
Contributor
Author
I don't see the need for writing test for just that commit while the whole project has no tests, anyway I'm using that in production with no problems, I'll write tests in weekend If I had time |
Owner
|
@maherzaidoune Let me know if this is still valid. I will go ahead and merge it. |
Contributor
Author
I'm using that from my fork till now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use this.props.selectedTab instead of state.selected and remove unnecessary logic inside componentWillReceiveProps