Skip to content

[wasm] Bump chrome version used for testing #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[wasm] Bump chrome version used for testing #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cce0c1
Use local variable for entries in dictionary enumerator
yesmey Aug 19, 2023
ea0595e
Automated bump of chrome version
github-actions[bot] Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions eng/testing/ChromeVersions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<Project>
<PropertyGroup>
<linux_ChromeVersion>115.0.5790.170</linux_ChromeVersion>
<linux_ChromeRevision>1148114</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1148123</linux_ChromeBaseSnapshotUrl>
<linux_ChromeVersion>116.0.5845.96</linux_ChromeVersion>
<linux_ChromeRevision>1160321</linux_ChromeRevision>
<linux_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1160321</linux_ChromeBaseSnapshotUrl>

<win_ChromeVersion>115.0.5790.171</win_ChromeVersion>
<win_ChromeRevision>1148114</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1148119</win_ChromeBaseSnapshotUrl>
<win_ChromeVersion>116.0.5845.97</win_ChromeVersion>
<win_ChromeRevision>1160321</win_ChromeRevision>
<win_ChromeBaseSnapshotUrl>https://storage.googleapis.com/chromium-browser-snapshots/Win_x64/1160375</win_ChromeBaseSnapshotUrl>
</PropertyGroup>
</Project>
17 changes: 11 additions & 6 deletions src/libraries/System.Private.CoreLib/src/System/Collections/Generic/Dictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,12 +1389,12 @@ public bool MoveNext()
ThrowHelper.ThrowInvalidOperationException_InvalidOperation_EnumFailedVersion();
}

Entry[]? entries = _dictionary._entries;
// Use unsigned comparison since we set index to dictionary.count+1 when the enumeration ends.
// dictionary.count+1 could be negative if dictionary.count is int.MaxValue
while ((uint)_index < (uint)_dictionary._count)
{
ref Entry entry = ref _dictionary._entries![_index++];

ref Entry entry = ref entries![_index++];
if (entry.next >= -1)
{
_current = new KeyValuePair<TKey, TValue>(entry.key, entry.value);
Expand Down Expand Up @@ -1631,10 +1631,12 @@ public bool MoveNext()
ThrowHelper.ThrowInvalidOperationException_InvalidOperation_EnumFailedVersion();
}

Entry[]? entries = _dictionary._entries;
// Use unsigned comparison since we set index to dictionary.count+1 when the enumeration ends.
// dictionary.count+1 could be negative if dictionary.count is int.MaxValue
while ((uint)_index < (uint)_dictionary._count)
{
ref Entry entry = ref _dictionary._entries![_index++];

ref Entry entry = ref entries![_index++];
if (entry.next >= -1)
{
_currentKey = entry.key;
Expand Down Expand Up @@ -1825,16 +1827,19 @@ public bool MoveNext()
ThrowHelper.ThrowInvalidOperationException_InvalidOperation_EnumFailedVersion();
}

Entry[]? entries = _dictionary._entries;
// Use unsigned comparison since we set index to dictionary.count+1 when the enumeration ends.
// dictionary.count+1 could be negative if dictionary.count is int.MaxValue
while ((uint)_index < (uint)_dictionary._count)
{
ref Entry entry = ref _dictionary._entries![_index++];

ref Entry entry = ref entries![_index++];
if (entry.next >= -1)
{
_currentValue = entry.value;
return true;
}
}

_index = _dictionary._count + 1;
_currentValue = default;
return false;
Expand Down